(feat) O3-1422 / O3-2724: Move workspace system into the framework #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
4 tasks
Merged
3 tasks
|
Yikes. I have not worked on |
|
The first of those errors is why every declare module '*.scss';That makes the TS compiler happy. The second one is probably one we've been ignoring because we usually have |
|
Sorry, yeah, forgot to mention that actually the first thing I tried was adding those declarations back to I've had so little luck getting anything to have any effect at all that I tried deleting the contents of Deleting the whole contents of |
|
Alright, so we had that commit that moved the ambient declarations from the styleguide into the framework. By adding that explicitly to the includes, it appears to fix the TS issues. Possibly the ambient types are not exported from |
|
Size Change: -1.91 MB (-14%) 👏 Total Size: 11.7 MB
ℹ️ View Unchanged
|
3 tasks
|
Amazing, thank you @ibacher . Good thinking, that makes sense. This PR is now actually fully ready for review. |
denniskigen
approved these changes
May 6, 2024
There was a problem hiding this comment.
LGTM, @brandones. Excellent work. Are we deprecating registerWorkspace? And can we update the naming conventions in the docs to include the new workspace and modal suffixes?
|
Good to go, @ibacher? |
Yes. The workspace registration via routes.json is basically an improvement in almost every way.
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPENDS ON: openmrs/openmrs-esm-core#979
Requirements
Summary
Apologies for the big PR. It is generally quite trivial. I have gone through and tested every single app that has a workspace.
Screenshots
See the main core change.
Related Issue
https://openmrs.atlassian.net/browse/O3-1421
https://openmrs.atlassian.net/browse/O3-2724
Other
Depends on openmrs/openmrs-esm-core#979