(fix) O3-3187: Fix borders used to highlight abnormal vitals #1848
Conversation
There was a problem hiding this comment.
Thanks for the work on this @Twiineenock! I'm hoping we can keep the change here as simple as possible.
| @@ -13,12 +19,22 @@ | |||
| } | |||
| } | |||
|
|
|||
| .criticallyLow, .criticallyHigh { | |||
| .criticallyHigh span, .criticallyLow span { | |||
There was a problem hiding this comment.
And the same in similar places...
| .criticallyHigh span, .criticallyLow span { | |
| .criticallyHigh > span, .criticallyLow > span { |
There was a problem hiding this comment.
@ibacher I have updated the PR to meet this. Thanks!
| padding-left: 1rem; | ||
| padding-top: 0.25rem; | ||
| padding-bottom: 0.25rem; |
There was a problem hiding this comment.
Why doesn't, e.g., padding: 0.25rem work? Also, it would be better to use Carbon's spacing variables instead of hard-coding various paddings...
There was a problem hiding this comment.
@ibacher the PR now has Carbon spacing variables.
I din't use padding: 0.25rem which is now $spacing-02 used padding-left: $spacing-05 to align the abnormal values in line with the normal values which were not styled.
this is how the Datable looks with padding: $spacing-02
Thanks!
packages/esm-patient-vitals-app/src/vitals/paginated-vitals.component.tsx
Show resolved
Hide resolved
denniskigen
changed the title
|
@cduffy2 @paulsonder Could one of you give us a thumbs up or thumbs down on the updated screen here? |
|
Fine for now, I think. We can improve the visual in the future |
Requirements
Summary
This PR fixes the inconsistent borders in the vitals table.
A discussion has been going synchronously in this ticket
and on slack.
Screenshots
previously the UI looked like this
The UI looks like this with the implementation in this PR
Related Issue
Vitals table border issues - O3-3187
Other