Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) O3-3372: Use React Form Engine in E2E Tests #1859

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

jayasanka-sack
Copy link
Member

@jayasanka-sack jayasanka-sack commented Jun 5, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

The OpenMRS distribution and O3 environments are currently utilizing the React form engine. To ensure consistency and improve testing accuracy, we need to incorporate the React form engine (form-engine-app) in our E2E tests.

Screenshots

Related Issue

https://openmrs.atlassian.net/browse/O3-3372

Other

@jayasanka-sack jayasanka-sack changed the title Use React Form Engine (form-engine-app) in E2E Tests (chore) O3-3372: Use React Form Engine in E2E Tests Jun 5, 2024
@jayasanka-sack jayasanka-sack marked this pull request as draft June 5, 2024 17:44
@jayasanka-sack jayasanka-sack marked this pull request as ready for review June 26, 2024 14:31
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @jayasanka-sack!

@denniskigen denniskigen merged commit ac9ae85 into openmrs:main Jun 26, 2024
6 checks passed
@@ -19,7 +19,7 @@ const config: PlaywrightTestConfig = {
use: {
baseURL: `${process.env.E2E_BASE_URL}/spa/`,
storageState: 'e2e/storageState.json',
video: 'retain-on-failure',
video: 'on',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we mean to make this change permanent?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh!! my bad it was meant to be temporary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed with 3b7377d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants