(fix) O3-3473: Fix results viewer print modal date range selection #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
requested review from
jayasanka-sack,
NethmiRodrigo,
vasharma05 and
donaldkibet
|
Size Change: -7.03 kB (-0.06%) Total Size: 11.1 MB ℹ️ View Unchanged
|
|
Any idea why the spec is failing, @jayasanka-sack? |
jayasanka-sack
force-pushed
the
fix/O3-3473-followup
branch
from
c642623 to
da9cab5
Compare
|
@denniskigen, the tests were a bit flaky, so I updated them with this PR: #1885. I initially pushed those commits to another PR but later decided to move them to a separate one. That’s why I had to force push to remove the commits. |
|
I've just merged the PR. Thank you, @jayasanka-sack! I've just rebased against main. Could you review this one? |
jayasanka-sack
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR is a follow-up to #1878. It amends the date comparison logic determining which test results to show for the selected date range. Currently, this logic doesn't consider the timestamps associated with the dates. I've added logic that considers the associated timestamps and validates that the End date cannot be earlier than the Start date. I'm also disabling the print modal's Print action button only if there are no test results to print.
Screenshots
print-results-viewer.mp4
Related Issue
https://openmrs.atlassian.net/browse/O3-3473
Other