Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(test) O3-3361: E2E test that data isn't lost when opening a workspace from another workspace #1886

Merged
merged 10 commits into from
Jul 8, 2024

Conversation

chimanwadike
Copy link
Contributor

@chimanwadike chimanwadike commented Jul 1, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR is an additional test steps in clinical-forms.spec to ensure form inputs are retained when navigating in and out of different workspaces.

Related Issue

https://issues.openmrs.org/browse/O3-3361

@chimanwadike chimanwadike marked this pull request as ready for review July 1, 2024 18:43
Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @chimanwadike! This should be implemented as a new test, as shown in the video provided in the ticket:

https://www.loom.com/share/d4b5f7bf310848e596193386707e8bb9

@chimanwadike
Copy link
Contributor Author

chimanwadike commented Jul 4, 2024

Thanks @jayasanka-sack
Going by the content of the video, I couldn't find the Clinical Encounter on any instance (both locally and pointing to dev3). However, available forms should be used I guess.

Regarding creating a new test for this. should this be a workspace_spec file or what are your thoughts about the filename, please?
Or a new test in clinical form spec?

Thanks for the PR, @chimanwadike! This should be implemented as a new test, as shown in the video provided in the ticket:

https://www.loom.com/share/d4b5f7bf310848e596193386707e8bb9

@jayasanka-sack
Copy link
Member

@brandones would it be okay to use the SOAP notes form for this?

Regarding creating a new test for this. should this be a workspace_spec file or what are your thoughts about the filename, please?

We can use the same spec to have multiple tests.

@chimanwadike chimanwadike marked this pull request as draft July 5, 2024 13:37
@chimanwadike chimanwadike marked this pull request as ready for review July 5, 2024 17:30
@brandones
Copy link
Contributor

@jayasanka-sack It doesn't matter to me what note it is, or what the data is. The important thing is that if I enter information on a workspace and then open another workspace from that one, the data I entered in the first workspace isn't lost when I go back to it.

@brandones brandones removed their request for review July 8, 2024 14:13
Copy link
Contributor

@brandones brandones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jayasanka-sack
Copy link
Member

Thanks for confirming @brandones !

@jayasanka-sack jayasanka-sack merged commit cef1867 into openmrs:main Jul 8, 2024
6 checks passed
@denniskigen
Copy link
Member

denniskigen commented Aug 7, 2024

This test is failing quite regularly in the CI environment. Can we review it when we get the chance?

CleanShot 2024-08-07 at 12  41 35@2x

@chimanwadike
Copy link
Contributor Author

chimanwadike commented Aug 10, 2024

Will look into it.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants