Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-3552: Add feature flag for printing patient identifier stickers #1893

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

jnsereko
Copy link
Contributor

@jnsereko jnsereko commented Jul 4, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Instead of using a config property to show the Print Patient Identifier Button, add the component as a feature flag
cc @denniskigen @vasharma05 @hadijahkyampeire

Screenshots

Screen.Recording.2024-07-08.at.09.41.27.mov

Related Issue

https://openmrs.atlassian.net/browse/O3-3552

Other

@denniskigen denniskigen requested a review from brandones July 4, 2024 18:23
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've left a few suggestions related to naming.

@denniskigen denniskigen changed the title Add Print Patient Identifier Sticker as a Feature Flag (feat) O3-3552: Add feature flag for printing patient identifier stickers Jul 5, 2024
@denniskigen
Copy link
Member

Thanks, @jnsereko!

@denniskigen denniskigen merged commit 9e466e8 into openmrs:main Jul 8, 2024
6 checks passed
chimanwadike pushed a commit to chimanwadike/openmrs-esm-patient-chart that referenced this pull request Jul 8, 2024
…kers (openmrs#1893)

(feat) Feature flag the ability to print identifier stickers

Co-authored-by: Dennis Kigen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants