-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Remove deprecated workspace components and fix tests #1896
Merged
denniskigen
merged 1 commit into
main
from
fix/remove-deprecated-components-and-fix-tests
Jul 5, 2024
Merged
(fix) Remove deprecated workspace components and fix tests #1896
denniskigen
merged 1 commit into
main
from
fix/remove-deprecated-components-and-fix-tests
Jul 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -4.57 kB (-0.04%) Total Size: 11.1 MB
ℹ️ View Unchanged
|
denniskigen
force-pushed
the
fix/remove-deprecated-components-and-fix-tests
branch
from
July 4, 2024 18:46
f962749
to
40cee1d
Compare
denniskigen
force-pushed
the
fix/remove-deprecated-components-and-fix-tests
branch
from
July 4, 2024 19:05
40cee1d
to
bde59ab
Compare
@jayasanka-sack is the results viewer spec still flaky? |
ibacher
approved these changes
Jul 5, 2024
It seems to be the case. I'll try to figure out why later. |
chimanwadike
pushed a commit
to chimanwadike/openmrs-esm-patient-chart
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR removes some deprecated components following the workspace refactor and updates the
DefaultPatientWorkspace
type annotation to include a setTitle function prop.Screenshots
Related Issue
Other