(fix) O3-3469: Fix allergy data tile display for severe allergies #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
changed the title
|
Size Change: -6.5 kB (-0.06%) Total Size: 11.1 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Thanks for the PR @denniskigen ! Why is that icon not displaying at all?
I recall there was an icon before, and I particularly liked the highlight effect. Is this change due to a design decision, or is it a temporary fix?
igone the red lines, took this screenshot from a previous PR.
|
@jayasanka-sack I removed the bell icon next to "Severe allergies" because it's based on an outdated iteration of the O3 designs. The current Allergies UI on Zeplin doesn't include it. Additionally, the SVG wouldn't render because the image sprite and supporting CSS were removed in this pull request. Check the |
jayasanka-sack
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR fixes an issue with the display of severe allergies in the Allergies Summary datatable by removing the bell SVG icon.
Screenshots
Before
After
Related Issue
https://openmrs.atlassian.net/browse/O3-3469
Other