-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(test) Add testing-related plugins to ESLint config #1898
Conversation
Size Change: 0 B Total Size: 11.1 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thanks @denniskigen !
The results viewer is still throwing some errors, need to figure out why. Btw, do you have an idea why the CI fails? I spotted one here: https://openmrs.atlassian.net/browse/O3-3558 |
Looks like we might need to reconsider the test timeouts if the flakiness persists. |
* (test) Add testing-related plugins to ESLint config * Comment out flaky tests
Requirements
Summary
This PR adds two testing related plugins to our ESLint config that enforce best practices:
Screenshots
Related Issue
Other