(fix) O3-3547: Handle possibly undefined encounter.obs in LabResultsForm

[PiusKariuki]

Requirements

• This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
• My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
• My work includes tests or is validated by existing tests.

Summary

This PR fixes an issue in the LabResultsForm component where clicking the Add results button from the OrderDetails table overflow menu would sometimes fail to successfully launch the form.

To remedy this, I've tweaked the logic so that the code that sets obsUuid and isEditing is in a useEffect hook. This ensures that we only try to access encounter.obswhen it is available and not undefined. I've also moved the logic for fetching initial values into a separate useEffect hook that depends on isEditing and obsUuid.

Screenshots

• This is a recording of the issue
  patient-orders-result-error.webm

• This is the recording after the fix
  fix-add-results.webm

Related Issue

LINK TO JIRA TICKET

Other

[PiusKariuki]

@brandones Please help me review this PR.

[pirupius]

Thanks @PiusKariuki for this. Did you test this with lab sets?

[PiusKariuki]

@pirupius Yes I did. I used a list of lab tests

…

On Mon, 8 Jul 2024, 6:09 pm Pius Rubangakene, ***@***.***> wrote: Thanks @PiusKariuki <https://github.com/PiusKariuki> for this. Did you test this with lab sets? — Reply to this email directly, view it on GitHub <#1903 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJMOARGZPDRANPFW3LRD64LZLKTR7AVCNFSM6AAAAABKQSTYKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJUGM4TIMRRHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[pirupius]

Is there work that hasn't been committed yet? The video recording in your PR description shows it's working but i've pulled your branch and it has the same error

Screen.Recording.2024-07-09.at.08.40.24.mov

[PiusKariuki]

@pirupius I have not experienced this behaviour let me test it again then I'll ping you on slack