(fix) O3-3609: Fix program enrollment eligibility logic #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -147 B (0%) Total Size: 11.1 MB ℹ️ View Unchanged
|
denniskigen
changed the title
denniskigen
requested review from
donaldkibet,
jwnasambu,
jayasanka-sack,
samuelmale and
NethmiRodrigo
|
@denniskigen thanks for this though I have a concern. I have tested the changes and am still confused to see the inline notification displayed at the same time the |
There was a problem hiding this comment.
Thanks for the PR @denniskigen! Shall we include a unit test for this behavior?
denniskigen
force-pushed
the
fix/program-enrollment-eligibility
branch
from
9bcb0e8 to
935e53c
Compare
|
Done, @jayasanka-sack. Thanks for raising the concern, @jwnasambu. I've had a design discussion (still ongoing) with Ciaran and Paul on ux-design-advisory where we've resolved to disable the Here's some screeenshots showing the current state of things: When the condition is met (i.e., the patient is already enrolled in all the available programs)
When the condition is not met
|
jayasanka-sack
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
The logic determining patient eligibility for program enrollment needs refinement. This PR addresses the following adjustments:
Enrollment Warning:
No Programs Configured Warning:
Changes Implemented
Screenshots
Current behaviour
current-behaviour.mp4
After the fix
program-enrollment-eligibility.mp4
Related Issue
https://openmrs.atlassian.net/browse/O3-3609
Other