-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "(feat) O3-2953: Add the ability to edit and delete vitals and biometrics" #1923
Merged
denniskigen
merged 3 commits into
main
from
revert/edit-and-delete-vitals-and-biometrics
Jul 17, 2024
Merged
Revert "(feat) O3-2953: Add the ability to edit and delete vitals and biometrics" #1923
denniskigen
merged 3 commits into
main
from
revert/edit-and-delete-vitals-and-biometrics
Jul 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
requested review from
ibacher,
vasharma05,
jayasanka-sack,
samuelmale and
dkayiwa
July 17, 2024 09:05
Size Change: -126 kB (-1.12%) Total Size: 11.1 MB
ℹ️ View Unchanged
|
ibacher
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, unfortunately, this is necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Reverts #1812
The current approach to editing vitals and biometrics creates new observations under the same encounter instead of updating existing ones. This results in many duplicate, non-voided observations.
When updating observations, we need a way to semantically indicate that the new observation is an updated version of an existing one. Each new observation in the payload should have the same UUID as the existing observation. This will ensure that we update observations in place instead of creating new ones.
This feature will be reintroduced after the 3.1.0 release.
Screenshots
Related Issue
Other