(fix)O3-2579 Lab results: Too much grey space #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sherrif10 here is a cleaner PR |
sherrif10
approved these changes
Jul 17, 2024
| @@ -75,6 +74,9 @@ | |||
| background-color: $color-gray-30; | |||
| grid-template: auto auto / 9em auto; | |||
| border-collapse: collapse; | |||
|
|
|||
| width: fit-content; | |||
There was a problem hiding this comment.
Looks good to me. Thanks @suubi-joshua , cc @denniskigen
There was a problem hiding this comment.
Shouldn't all panels consistently take up the entire available space without fitting to the individual content sizes?
More so like:
There was a problem hiding this comment.
Yes this looks more neat. @NethmiRodrigo
brandones
reviewed
Sep 15, 2024
packages/esm-patient-labs-app/src/test-results/panel-timeline/timeline.scss
Outdated
Show resolved
Hide resolved
|
I assume the two videos in the description should be labeled "Before" and "After." |
brandones
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Removed the background color of the results grid.
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-2579
Other
Screencast.from.07-17-2024.12.37.13.AM.webm
Screencast.from.07-17-2024.09.51.57.PM.webm