-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) O3-3573: The Modify order action should take one to modify the order #1928
(fix) O3-3573: The Modify order action should take one to modify the order #1928
Conversation
@@ -107,14 +107,11 @@ const OrderDetailsTable: React.FC<OrderDetailsProps> = ({ title, patientUuid, sh | |||
case 'drugorder': | |||
launchAddDrugOrder(); | |||
break; | |||
case 'testorder': | |||
launchAddLabsOrder(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't this have been solved by changing this to:
launchAddLabsOrder({order: orderItem});
That seems like a cleaner immplementation to me. Closing the workspace seems like it would potentially have undesirable side-effects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ibacher I have removed the implementation to close the workspace and made another push. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd still like if we could go back to using this switch. It makes it easier when we need to implement additional order types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ibacher reverted to the switch statement; implementation is slightly different from the suggested launchAddLabsOrder({order: orderItem});
cause it was loading a blank form. Thanks
48055ae
to
d343440
Compare
d343440
to
73e84a6
Compare
Thanks @miirochristopher! |
Requirements
Summary
Currently, when, in the Orders view of the patient chart, you select “Modify order“, it takes you to the Add lab order view of the order basket with all lab tests. Instead, it should take you to this screen, i.e., where I can actually modify the order.
Screenshots
modify-order.mp4
Related Issue
Other