Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-3573: The Modify order action should take one to modify the order #1928

Conversation

miirochristopher
Copy link
Contributor

@miirochristopher miirochristopher commented Jul 18, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Currently, when, in the Orders view of the patient chart, you select “Modify order“, it takes you to the Add lab order view of the order basket with all lab tests. Instead, it should take you to this screen, i.e., where I can actually modify the order.

Screenshots

modify-order.mp4

Related Issue

Other

@ibacher ibacher requested a review from brandones July 18, 2024 19:16
@@ -107,14 +107,11 @@ const OrderDetailsTable: React.FC<OrderDetailsProps> = ({ title, patientUuid, sh
case 'drugorder':
launchAddDrugOrder();
break;
case 'testorder':
launchAddLabsOrder();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't this have been solved by changing this to:

launchAddLabsOrder({order: orderItem});

That seems like a cleaner immplementation to me. Closing the workspace seems like it would potentially have undesirable side-effects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ibacher I have removed the implementation to close the workspace and made another push. Thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still like if we could go back to using this switch. It makes it easier when we need to implement additional order types.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ibacher reverted to the switch statement; implementation is slightly different from the suggested launchAddLabsOrder({order: orderItem}); cause it was loading a blank form. Thanks

@ibacher ibacher removed the request for review from brandones July 18, 2024 19:23
@miirochristopher miirochristopher force-pushed the fix/O3-3573-the-modify-order-action-should-lead-to-modify-order branch from 48055ae to d343440 Compare July 18, 2024 22:06
@miirochristopher miirochristopher force-pushed the fix/O3-3573-the-modify-order-action-should-lead-to-modify-order branch from d343440 to 73e84a6 Compare July 19, 2024 09:42
@ibacher ibacher changed the title (fix) O3-3573: The Modify Order Action should take one to modify the order (fix) O3-3573: The Modify order action should take one to modify the order Jul 22, 2024
@ibacher ibacher merged commit 25bf8ed into openmrs:main Jul 22, 2024
6 checks passed
@ibacher
Copy link
Member

ibacher commented Jul 22, 2024

Thanks @miirochristopher!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants