-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
O3-3625 Lab Orders Completed via the Orders Section Still Show as Ord… #1931
Conversation
Size Change: +675 B (+0.01%) Total Size: 11.1 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CynthiaKamau, left a few review comments.
const loadInitialValues = async () => { | ||
if (isEditing && obsUuid) { | ||
setIsLoadingInitialValues(true); | ||
const data = await fetchObservation(obsUuid); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we abstract this data fetching logic into a hook?
obsPayload: any, | ||
fulfillerPayload: any, | ||
orderPayload: any, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a type for this or default to unknown
instead of using any
.
body: obsPayload, | ||
}); | ||
|
||
if (saveEncounter.status === 200 || saveEncounter.status === 201) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (saveEncounter.status === 200 || saveEncounter.status === 201) { | |
if (saveEncounter.ok) { |
…ered in the Laboratory Section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CynthiaKamau
…ered in the Laboratory Section
Requirements
Summary
Screenshots
Screen.Recording.2024-07-22.at.11.09.09.mov
Related Issue
Other