(feat) O3-3660: Show trend results view in a modal #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +592 B (0%) Total Size: 14.2 MB
ℹ️ View Unchanged
|
CynthiaKamau
force-pushed
the
O3-3660
branch
3 times, most recently
from
a175665 to
53f0d0f
Compare
|
Thanks @CynthiaKamau, kindly fix the test run failure. |
denniskigen
changed the title
denniskigen
requested changes
Aug 13, 2024
There was a problem hiding this comment.
Thanks, @CynthiaKamau. Mostly LGTM save for the modal registration and naming convention. I've left some recommendations.
packages/esm-patient-labs-app/src/test-results/panel-timeline/results-dialog.comoponent.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-labs-app/src/test-results/panel-timeline/timeline.scss
Outdated
Show resolved
Hide resolved
CynthiaKamau
force-pushed
the
O3-3660
branch
2 times, most recently
from
5d9bc26 to
6a1029e
Compare
|
It looks like the Trendline component UI doesn't quite match what is outlined in the design. Is there a plan to tackle this next? |
denniskigen
reviewed
Aug 13, 2024
packages/esm-patient-labs-app/src/test-results/panel-timeline/helpers.tsx
Show resolved
Hide resolved
denniskigen
reviewed
Aug 13, 2024
packages/esm-patient-labs-app/src/test-results/panel-timeline/timeline-results.modal.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Clicking on an individual test should open a trend view of that test in a modal. Clicking outside the modal closes the modal. The results table can be shown beneath the trend view, once the Show results table button has been clicked. After it’s clicked the text changes to Hide results table. The modal can be scrollable if necessary
Screenshots
Screen.Recording.2024-07-31.at.22.59.00.mov
Related Issue
https://openmrs.atlassian.net/browse/O3-3660
Other