(feat) O3-3748: Add data-openmrs-role data attributes to DOM elements
#1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
changed the title
data-openmrs-role data attributes to DOM elements
ibacher
approved these changes
Aug 7, 2024
denniskigen
force-pushed
the
enhnc/O3-3748
branch
from
a4ddab8 to
8fb7637
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR defines a proper way for selectors accesability. By having this, we can query element using
data-openmrs-rolein the dom.Screenshots
Related Issue
O3-3748
Other
As per this #comment
cc : @jayasanka-sack