-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(test) Add E2E test for editing existing visits #1956
Conversation
Size Change: 0 B Total Size: 14.2 MB ℹ️ View Unchanged
|
4de7def
to
8ad2821
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm not sure about this. @jayasanka-sack might have some ideas. |
Thanks, @kdaud. Let's wait for @jayasanka-sack's feedback then |
@denniskigen I tested the scenario and found that clearing the current location populates the dropdown list, letting you choose any option.
|
8ad2821
to
b18a9e4
Compare
Excellent, thanks @kdaud. I've pushed an update doing exactly that. |
Requirements
Summary
This PR adds an E2E test for editing existing visits in O3. It also renames the Start visit E2E test for clarity. This test covers the following scenarios:
One thing that's not adequately covered is the ability to change the visit location (which is what originally informed this work). How can I populate the dropdown with additional locations in the test environment @jayasanka-sack @kdaud?Screenshots
Related Issue
Other