(fix) O3-3715: Add phone number person attribute to patient banner config #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +30 B (0%) Total Size: 14.2 MB ℹ️ View Unchanged
|
ibacher
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
We had an issue before where I think the UUID for this wasn't stable, but it seems fine. Note, though, that if we're using the FHIR Patient object, it should already have the phone number in the telecom field, assuming that the FHIR2 module is configured (i.e., we should try to avoid needing to make unnecessary requests).
|
You're absolutely right! This uses the FHIR Patient object, and the telephone number is indeed included in the |
4 tasks
|
We should probably get this in, then @ibacher. |
ibacher
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Telephone numbers recorded during patient registration don't show up in the patient header. This is because the default contact person attribute types array in the Patient Banner config is set to an empty array. That's problematic because the logic that determines which attributes to show under the contact details section checks the patient's attributes against that array. This PR adds a person attribute UUID for the Telephone number attribute as a default value in the
contactAttributeTypesarray, which fixes the root issue.Screenshots
Bug
telephone_missing_patient_header.mov
Fix
Related Issue
https://openmrs.atlassian.net/browse/O3-3715
Other