-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) O3-3781: Custom Widgets throwing error when rendering. #1967
Conversation
@usamaidrsk, the PR titles should be specific to user case, instead of technical issue/ improvement. Then the description will state the technical issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@usamaidrsk , please add a screenshot, @kazlaw can you please provide the configuration for adding a custom widget?
Thanks!
@vasharma05 , @usamaidrsk something like this "extensionSlots": {
"patient-chart-summary-dashboard-slot": {
"add": [
"obs-by-encounter-widget#consultation"
],
"order": [
"obs-by-encounter-widget#consultation"
],
"configure": {
"obs-by-encounter-widget#consultation": {
"title": "Motif de consultation",
"showGraphByDefault": true,
"encounterTypes": [
"f9fdbe63-12b4-479f-b8fd-dcbfde6aa944"
],
"Display conditions": {
"privileges": [
"Add Users"
]
},
"data": [
{
"label": "Motif de consultation",
"concept": "0a061333-1611-45b3-8096-f7c339b4fdfc",
"color": "blue"
},
{
"label": "Duration",
"concept": "d178d5cf-52c3-4722-bb12-5861daa2815c",
"color": "green"
},
{
"label": "Time Units",
"concept": "d6593e37-b7a8-482b-856f-6f6a8db25508",
"color": "green"
}
],
"table": {
"pageSize": 6
}
}
}
}
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting the fix in, since it's kind of a no-brainer. Though fleshing out the associated PR documentation as requested is quite welcome. Thanks @usamaidrsk
The fix is trivial and very sensible, obviously the right thing to do
Requirements
Summary
Fix can not read from undefined Custom Widget.
A quick test, use this config, provided by Reagan on this slack thread
Screenshots
Related Issue
Other
https://openmrs.atlassian.net/browse/O3-3781