(feat) Lab results form improvements #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes the following improvements to the lab results form following the recent change to make it the single source of truth for lab orders: - Refactors the error notification shown when the user tries to submit the form without filling any fields to use the Carbon InlineNotification component - Refactors the logic used to determine whether the form is empty to leverage the getValues method of react-hook-form - Increases the Stack gap to 1rem to make the form more spacious - Removes error handling concerns from the form field component - Refactors the form field component to use the Carbon TextInput or NumberInput components based on the concept datatype - Renames the result form field component to lab results form field component
3 tasks
|
Size Change: -144 kB (-0.99%) Total Size: 14.3 MB
ℹ️ View Unchanged
|
|
Looks like the e2e test failures are due to the test setup failing (unrelated to this PR AFAICT):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR makes the following improvements to the lab results form following the recent change to make it the single source of truth for lab orders:
Screenshots
mods.mp4
Related Issue
https://openmrs.atlassian.net/browse/O3-3809
https://openmrs.atlassian.net/browse/O3-3813
Other