(feat) O3-3797: Add the Encounter List Table and Tabs to Patient Chart #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -197 kB (-1.21%) Total Size: 16 MB
ℹ️ View Unchanged
|
hadijahkyampeire
force-pushed
the
O3-3797-encounter-list-table
branch
from
9d98eb8 to
582b365
Compare
hadijahkyampeire
changed the title
hadijahkyampeire
force-pushed
the
O3-3797-encounter-list-table
branch
2 times, most recently
from
a75476f to
a530bbe
Compare
kajambiya
reviewed
Sep 10, 2024
packages/esm-patient-chart-app/src/clinical-views/utils/helpers.ts
Outdated
Show resolved
Hide resolved
hadijahkyampeire
force-pushed
the
O3-3797-encounter-list-table
branch
from
2577187 to
f02eef5
Compare
hadijahkyampeire
force-pushed
the
O3-3797-encounter-list-table
branch
from
d20819d to
e912834
Compare
ibacher
requested changes
Sep 28, 2024
packages/esm-patient-chart-app/src/clinical-views/utils/helpers.ts
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/clinical-views/utils/helpers.ts
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/clinical-views/utils/helpers.ts
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/clinical-views/utils/helpers.ts
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/clinical-views/utils/helpers.ts
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/encounter-list/components/encounter-list.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/encounter-list/components/encounter-list.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/encounter-list/components/encounter-list.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/encounter-list/components/encounter-list.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/encounter-list/components/encounter-list.component.tsx
Outdated
Show resolved
Hide resolved
CynthiaKamau
force-pushed
the
O3-3797-encounter-list-table
branch
2 times, most recently
from
87fe3eb to
e2ffc01
Compare
ibacher
requested changes
Oct 11, 2024
packages/esm-patient-chart-app/src/encounter-list/hooks/useFormsJson.ts
Outdated
Show resolved
Hide resolved
| responses | ||
| .map((response, index) => { | ||
| const match = | ||
| response?.data ?? response?.data?.find((result) => !result.retired && result.name === formUuids[index]); |
There was a problem hiding this comment.
fetchOpenMRSForms() returns an array of Form results, but each of those will have the Form object as the response.data, so response.data is not an array of objects and so find will always be undefined.
packages/esm-patient-chart-app/src/encounter-list/hooks/useFormsJson.ts
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/encounter-list/hooks/usePatientDeathStatus.ts
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/encounter-list/hooks/usePatientDeathStatus.ts
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/encounter-list/components/encounter-list.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/clinical-views/utils/helpers.ts
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/clinical-views/utils/helpers.ts
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/clinical-views/utils/helpers.ts
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/clinical-views/utils/helpers.ts
Outdated
Show resolved
Hide resolved
ibacher
reviewed
Oct 25, 2024
packages/esm-patient-chart-app/src/clinical-views/utils/helpers.ts
Outdated
Show resolved
Hide resolved
|
Ping @hadijahkyampeire , is it clear to you how to move forward with this? |
|
@brandones I think @CynthiaKamau or @ODORA0 will be taking this on as I am currently unavailable to work. Thanks |
|
@CynthiaKamau or @ODORA0 will you be taking this on? |
i will take it up |
CynthiaKamau
force-pushed
the
O3-3797-encounter-list-table
branch
4 times, most recently
from
397aa4c to
238ea77
Compare
There was a problem hiding this comment.
Thanks @CynthiaKamau! Didn't quite make it through the entire PR yet, but a left a few comments about suggestions or questions I had
packages/esm-patient-chart-app/src/encounter-list/utils/encounter-list-config-builder.ts
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/encounter-list/utils/encounter-list-config-builder.ts
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/encounter-list/utils/encounter-list-config-builder.ts
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/encounter-list/components/encounter-list-tabs.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/encounter-list/components/encounter-list.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/encounter-list/components/encounter-list.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/encounter-list/components/encounter-list.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/encounter-list/components/encounter-list.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/encounter-list/components/encounter-list.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/encounter-list/components/encounter-list.component.tsx
Outdated
Show resolved
Hide resolved
CynthiaKamau
force-pushed
the
O3-3797-encounter-list-table
branch
from
983d5f1 to
7dfadc2
Compare
3 tasks
ibacher
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Screenshots
encounter-list-tables.mov
Related Issue
Other