(feat) O3-3901 Add support for program states in esm-patient-programs #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
reviewed
Sep 9, 2024
There was a problem hiding this comment.
Thanks, @ynurmahomed! Great start. Just a bunch of suggestions about using the config schema to make this new behaviour configurable.
packages/esm-patient-programs-app/src/programs/programs-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-programs-app/src/programs/programs-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-programs-app/src/programs/programs-form.workspace.tsx
Show resolved
Hide resolved
denniskigen
reviewed
Sep 9, 2024
packages/esm-patient-programs-app/src/programs/programs-detailed-summary.test.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-programs-app/src/programs/programs-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-programs-app/src/programs/programs-form.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-programs-app/src/programs/programs.resource.tsx
Outdated
Show resolved
Hide resolved
|
@denniskigen Added your suggestions, please review again. |
denniskigen
force-pushed
the
O3-3901
branch
from
7f838ff to
e716e57
Compare
denniskigen
approved these changes
Sep 10, 2024
denniskigen
force-pushed
the
O3-3901
branch
from
e716e57 to
fedb777
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Screenshots
Related Issue
Other