-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-3899: Tweak photo picker in the registration form #1994
(feat) O3-3899: Tweak photo picker in the registration form #1994
Conversation
FYI @usamaidrsk , @vasharma05 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Twiineenock for the work, I have a few suggestions.
I am not sure if this component is only used to capture patient image, I will refer that to @denniskigen or @vasharma05 to confirm.
...es/esm-patient-attachments-app/src/camera-media-uploader/camera-media-uploader.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-attachments-app/src/camera-media-uploader/capture-photo.scss
Outdated
Show resolved
Hide resolved
packages/esm-patient-attachments-app/src/camera-media-uploader/capture-photo.scss
Outdated
Show resolved
Hide resolved
packages/esm-patient-attachments-app/src/camera-media-uploader/capture-photo.scss
Outdated
Show resolved
Hide resolved
packages/esm-patient-attachments-app/src/camera-media-uploader/capture-photo.scss
Outdated
Show resolved
Hide resolved
ec67c41
to
104ae0c
Compare
104ae0c
to
29f8641
Compare
29f8641
to
26dbca2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Addressed in subsequent commits
Requirements
Summary
This PR resolves several issues with the photo picker as described in detail within this ticket. The updates are based on the design outlined here, aimed at improving user experience and functionality.
Screenshots
Addition mode(No image to display)
Edit mode(changing an image)
Related Issue
https://openmrs.atlassian.net/browse/O3-3899
Other
Screancast to demonstrate the workflow
photo-picker-2.webm