Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-3899: Tweak photo picker in the registration form #1994

Merged
merged 8 commits into from
Sep 16, 2024

Conversation

Twiineenock
Copy link
Contributor

@Twiineenock Twiineenock commented Sep 5, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR resolves several issues with the photo picker as described in detail within this ticket. The updates are based on the design outlined here, aimed at improving user experience and functionality.

  • Enabled users to add or change an image directly in place.
  • Integrated upload files and webcam options within the same context for enhanced flexibility.
  • Updated the edit button functionality to toggle between add mode and change mode.

Screenshots

Addition mode(No image to display)
add-mode

Edit mode(changing an image)
edit-mode-2

Related Issue

https://openmrs.atlassian.net/browse/O3-3899

Other

Screancast to demonstrate the workflow

photo-picker-2.webm

@Twiineenock Twiineenock marked this pull request as draft September 5, 2024 07:26
@Twiineenock Twiineenock marked this pull request as ready for review September 5, 2024 13:33
@Twiineenock
Copy link
Contributor Author

FYI @usamaidrsk , @vasharma05

@usamaidrsk usamaidrsk requested review from vasharma05, usamaidrsk and denniskigen and removed request for vasharma05 September 5, 2024 16:22
Copy link
Member

@usamaidrsk usamaidrsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Twiineenock for the work, I have a few suggestions.

I am not sure if this component is only used to capture patient image, I will refer that to @denniskigen or @vasharma05 to confirm.

@denniskigen denniskigen force-pushed the feat/improve-photo-picker branch from ec67c41 to 104ae0c Compare September 16, 2024 17:03
@denniskigen denniskigen changed the title (feat) O3-3899: Improve photo picker within patient-registration form (feat) O3-3899: Tweak photo picker in the registration form Sep 16, 2024
@denniskigen denniskigen force-pushed the feat/improve-photo-picker branch from 104ae0c to 29f8641 Compare September 16, 2024 17:38
@denniskigen denniskigen force-pushed the feat/improve-photo-picker branch from 29f8641 to 26dbca2 Compare September 16, 2024 18:29
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denniskigen denniskigen dismissed usamaidrsk’s stale review September 16, 2024 19:06

Addressed in subsequent commits

@denniskigen denniskigen merged commit 3f44627 into openmrs:main Sep 16, 2024
6 checks passed
@denniskigen denniskigen mentioned this pull request Dec 17, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants