Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Pass default form session intent to form Engine #2004

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

kajambiya
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR addresses an issue where session intents were not being passed when opening forms from the clinical-forms-workspace. The React form engine supports session intents, allowing business rules to be applied per intent via the behaviors property. However, forms created with intents were not applying the corresponding business rules due to the absence of intents when the form was opened.

To resolve this, the PR sets * (all) as the default intent when opening a form. This change ensures that business rules are applied to forms with intents while having no impact on forms without intents.

Screenshots

Related Issue

Other

@pirupius pirupius merged commit 29bf5e9 into openmrs:main Sep 9, 2024
6 checks passed
@denniskigen denniskigen mentioned this pull request Dec 17, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants