(feat) O3-3818: Extend clinical forms workspace #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +79 B (0%) Total Size: 14.8 MB ℹ️ View Unchanged
|
3 tasks
|
This PR depends on this PR #2018 |
3 tasks
mogoodrich
reviewed
Sep 18, 2024
chibongho
approved these changes
Sep 18, 2024
usamaidrsk
force-pushed
the
ft-O3-3818
branch
from
ebea026 to
23838da
Compare
|
Okay so it looks like the deeper problem this is trying to mitigate is that really we don't want workspaces themselves to have to say whether they are part of a sidebar family or not. That really should be defined by the workspace container. Then we will just be able to reuse the same workspaces from the patient chart in the ward app, without having to do this awkward duplicate definition thing. I have filed O3-4077 to suggest a fix for the workspace system. CC @ibacher @denniskigen @chibongho @vasharma05 , or if someone wants to find me a contract to do it :) |
brandones
reviewed
Oct 10, 2024
Comment on lines
+42
to
+45
| export const clinicalFormsWorkspaceExtension = getAsyncLifecycle( | ||
| () => import('./forms/forms-dashboard.workspace'), | ||
| options, | ||
| ); |
There was a problem hiding this comment.
This is a duplicate declaration; it doesn't add anything. The code would be easier to understand if the extension registration simply referred to the clincialFormsWorkspace object. Then it would be immediately obvious we are doing something weird, rather than taking time to figure out we are doing something weird :)
senthil-athiban
pushed a commit
to senthil-athiban/openmrs-esm-patient-chart
that referenced
this pull request
Nov 19, 2024
* (feat) extend clinical forms workspace * (fix) fix failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR extends clinical forms workspace i.e(to the ward app). This it to eliminate where a user has to go to and fro from the patient chart to the ward app so as to fill forms.
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-3818
Other