(feat) Tweak Test results dashboard sticky header UI #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CynthiaKamau
force-pushed
the
O3-3655
branch
from
2523c5d to
d2160f0
Compare
|
Size Change: +1.07 kB (+0.01%) Total Size: 14.8 MB ℹ️ View Unchanged
|
|
Hi @CynthiaKamau! |
on it |
CynthiaKamau
force-pushed
the
O3-3655
branch
from
d2160f0 to
1ed0c59
Compare
denniskigen
force-pushed
the
O3-3655
branch
2 times, most recently
from
8feada1 to
5488af2
Compare
denniskigen
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Thanks, @CynthiaKamau. The approach looks OK to me, though I think it'd be preferable to use an IntersectionObserver instead. I've explained why in my review suggestion.
packages/esm-patient-labs-app/src/test-results/results-viewer/results-viewer.extension.tsx
Show resolved
Hide resolved
|
One other thing we might want to do is remove the top margin applied to the // See https://zpl.io/lrlmdq0 for the Visits dashboard design
[data-extension-slot-name='patient-chart-encounters-dashboard-slot'],
// See https://zpl.io/RmMXrDE for the Test Results dashboard design
[data-extension-slot-name='patient-chart-test-results-dashboard-slot'] {
margin: 0 layout.$spacing-05;
}Also, the conventional commit label used here should be |
CynthiaKamau
added
hacktoberfest-accepted
denniskigen
approved these changes
Oct 1, 2024
denniskigen
changed the title
senthil-athiban
pushed a commit
to senthil-athiban/openmrs-esm-patient-chart
that referenced
this pull request
Nov 19, 2024
* (feat) Add background color on scrolling sticky results menu * Fix test results dashboard margins * Commit orphaned translation --------- Co-authored-by: Dennis Kigen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Screenshots
Screen.Recording.2024-09-19.at.13.13.50.mov
Related Issue
Other