-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Fix required validation in Visit Note form #2025
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +846 B (+0.01%) Total Size: 14.8 MB ℹ️ View Unchanged
|
chibongho
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not too familiar with this code, but LGTM!
Tested and verified. @denniskigen @chibongho thanks. |
senthil-athiban
pushed a commit
to senthil-athiban/openmrs-esm-patient-chart
that referenced
this pull request
Nov 19, 2024
* (fix) Fix required validation in Visit Note form * Fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR fixes a regression in the required validation in the Visit Notes form. Presently, the zod schema associated with the form is meant to show a validation error if a user tries to submit the form without selecting a primary diagnosis. This doesn't work as expected. In this PR, I've fixed the validation by tweaking the schema to react to changes to the
selectedPrimaryDiagnosis
array (which gets populated when a primary diagnosis is selected).I've also restored some tests in the accompanying suite that had been commented out and added some coverage for the new behaviour.
Screenshots
Before
current-state.mp4
After
desired-state.mp4
Related Issue
Other