(fix): Remove automatic appending of Zeros to numeric lab results #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makombe
requested review from
arodidev,
donaldkibet,
CynthiaKamau and
ojwanganto
|
Thanks, @makombe. Please create a ticket and link it to the PR |
donaldkibet
approved these changes
Sep 24, 2024
denniskigen
reviewed
Sep 24, 2024
...nt-labs-app/src/test-results/individual-results-table/individual-results-table.component.tsx
Outdated
Show resolved
Hide resolved
|
Great catch, @makombe. Let me try to cobble up some test coverage to ensure we don't run into this again. |
|
Can I push a commit with the tests, @makombe? |
Sure. That would be great. |
|
Done. Thanks! |
senthil-athiban
pushed a commit
to senthil-athiban/openmrs-esm-patient-chart
that referenced
this pull request
Nov 19, 2024
…enmrs#2030) * (fix): Remove automatic appending of Zeros to numeric lab results * Code review * Useful mods --------- Co-authored-by: Dennis Kigen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
If you order a lab test and the results is a numeric value, there is always a zero added. This is quite misleading. I have provided an example of a actual viral load result which should be
303copies but presented to the user as3030copiesScreenshots
Before:
After:
Related Issue
Other