(feat) O3-4014: Add ability to warn user of unsaved changes on form-entry-app #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -515 kB (-3.36%) Total Size: 14.8 MB
ℹ️ View Unchanged
|
donaldkibet
requested review from
denniskigen,
ibacher,
makombe and
vasharma05
and removed request for
denniskigen
denniskigen
reviewed
Sep 24, 2024
packages/esm-form-entry-app/src/app/fe-wrapper/fe-wrapper.component.ts
Outdated
Show resolved
Hide resolved
|
One other thing worth doing is cleaning up the subscription when the component unmounts. We could use something like: private workspaceDirtyStateListenerSubscription: Subscription;
public ngOnDestroy() {
// ... existing code
this.workspaceDirtyStateListenerSubscription?.unsubscribe();
}
// and then...
private setupWorkspaceDirtyStateListener(): void {
const promptBeforeClosing = this.singleSpaPropsService.getPropOrThrow('promptBeforeClosing');
this.workspaceDirtyStateListenerSubscription = this.form.rootNode.control.valueChanges
.pipe(
map(() => this.form.rootNode.control.dirty),
filter((isDirty) => isDirty),
take(1),
)
.subscribe(() => {
promptBeforeClosing(() => true);
}); |
denniskigen
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Thanks for working on this, @donaldkibet. Generally LGTM sans a couple suggestions about using the form's actual dirty state and cleanup for the subscription to prevent memory leaks.
denniskigen
changed the title
donaldkibet
force-pushed
the
O3-4014
branch
from
79c5fc6 to
b766b91
Compare
donaldkibet
force-pushed
the
O3-4014
branch
from
b766b91 to
157fd04
Compare
senthil-athiban
pushed a commit
to senthil-athiban/openmrs-esm-patient-chart
that referenced
this pull request
Nov 19, 2024
…ntry-app (openmrs#2031) * (feat) : add ability to warn user of unsaved changes on form-entry-app * code reviews changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR adds ability to warn user before closing unsaved form while using angular form engine
Screenshots
Kapture.2024-09-24.at.14.38.19.mp4
Related Issue
Other