(feat) Order basket UI tweaks #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +4.58 kB (+0.03%) Total Size: 14.8 MB ℹ️ View Unchanged
|
denniskigen
force-pushed
the
feat/order-basket-ui-tweaks
branch
from
e540f84 to
93f0827
Compare
denniskigen
requested review from
ibacher,
vasharma05,
brandones,
samuelmale,
jayasanka-sack and
usamaidrsk
usamaidrsk
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Thanks @denniskigen, great work!
I have added some thoughts.
packages/esm-patient-labs-app/src/lab-orders/add-lab-order/test-type-search.component.tsx
Show resolved
Hide resolved
ibacher
approved these changes
Oct 7, 2024
| @@ -34,6 +34,7 @@ | |||
| order: 1; | |||
| margin-right: layout.$spacing-03; | |||
| margin-left: 0 !important; | |||
| fill: currentColor !important; | |||
There was a problem hiding this comment.
Yeah, I've got to sort this out. The broad issue is that we're using CSS to try to propagate the color, but Carbon tends to use more "specific" selectors to color things. And while it would be possible to use !important in the styleguide itself, it would make it impossible to override in parent CSS when appropriate...
This PR applies the following UI tweaks to the order basket: - Adjusts the fill color property of svg icons in buttons to match the `currentColor` value of the parent element. - Tweaks the search results pages of the order basket to display a "Return to order basket" button per the [designs](https://zpl.io/MdQEOXK). - Adds some top margin to the test type name in the lab order form. - Tweaks the skeleton loader of the lab order search page to match the medication order search page. - Tweaks to the medication order form including amending the field sizes for both tablet and desktop views.
denniskigen
force-pushed
the
feat/order-basket-ui-tweaks
branch
from
de66329 to
f1617c3
Compare
usamaidrsk
reviewed
Oct 7, 2024
packages/esm-patient-labs-app/src/lab-orders/add-lab-order/add-lab-order.workspace.tsx
Show resolved
Hide resolved
usamaidrsk
approved these changes
Oct 7, 2024
senthil-athiban
pushed a commit
to senthil-athiban/openmrs-esm-patient-chart
that referenced
this pull request
Nov 19, 2024
This PR applies the following UI tweaks to the order basket: - Adjusts the fill color property of svg icons in buttons to match the `currentColor` value of the parent element. - Tweaks the search results pages of the order basket to display a "Return to order basket" button per the [designs](https://zpl.io/MdQEOXK). - Adds some top margin to the test type name in the lab order form. - Tweaks the skeleton loader of the lab order search page to match the medication order search page. - Tweaks to the medication order form including amending the field sizes for both tablet and desktop views. Co-authored-by: Usama Idriss Kakumba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR applies the following UI tweaks to the order basket:
currentColorvalue of the parent element.Screenshots
Order basket UI (https://zpl.io/MdQEOXK)
order-basket-ui-tweaks.mp4
Order forms (tablet and desktop style tweaks) (https://zpl.io/blO3eB1)
order-forms.mp4
Related Issue
Other