(feat) O3-3839 Allowing of printing lab request #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +695 B (0%) Total Size: 15.9 MB ℹ️ View Unchanged
|
denniskigen
reviewed
Oct 16, 2024
| renderIcon={(props) => <PrinterIcon {...props} size={16} />} | ||
| iconDescription={t('print', 'Print')} | ||
| renderIcon={PrinterIcon} | ||
| iconDescription="Add vitals" |
| _type: Type.Boolean, | ||
| _default: false, | ||
| _description: | ||
| 'Determines whether or not to display the Print button in the orders. If set to true, a Print button gets shown in both the orders table headers. When clicked, this button enables the user to print out the contents of the table', |
There was a problem hiding this comment.
Suggested change
| 'Determines whether or not to display the Print button in the orders. If set to true, a Print button gets shown in both the orders table headers. When clicked, this button enables the user to print out the contents of the table', | |
| 'Determines whether or not to display a Print button in the Orders details table. If set to true, a Print button gets shown in both the orders table headers. When clicked, this button enables the user to print out the contents of the table', |
|
Also, this is technically a new feature, so the appropriate conventional commit label should be |
pirupius
changed the title
pirupius
reviewed
Oct 17, 2024
There was a problem hiding this comment.
I have some concerns about this. I believe the end product was for the user to be able to print the order request details. Typically, printing the list of orders might not add much value but printing for example the lab order details with the tests as well as results offer much more value.
Looking at the ticket, it doesn't say much about what needs to be achieved so maybe we should get clarification first.
it already existed, but was set to false by default, i just added a config to expose it |
i have pinged the design team, i'l be updating the layout after a design is created. Also not that after lab results are added, the order will be marked as complete and it wont be in this view anymore, so we will only be showing the test type (which is in the table ) and the normal range which is not part of the table, drugs have more details though @pirupius |
CynthiaKamau
force-pushed
the
O3-3839
branch
4 times, most recently
from
6c17a38 to
def0877
Compare
pirupius
reviewed
Oct 31, 2024
| ) : ( | ||
| '--' | ||
| ), | ||
| results: '--', |
There was a problem hiding this comment.
I've just noticed this, was it intentional to leave this blank? If there's no use case for it then we should just remove it
pirupius
approved these changes
Nov 4, 2024
senthil-athiban
pushed a commit
to senthil-athiban/openmrs-esm-patient-chart
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Allowing of printing lab request
Screenshots
Screen.Recording.2024-10-16.at.14.21.34.mov
Related Issue
Other