-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-4088: Sort diagnoses tags in visit summary by rank #2064
Conversation
Size Change: +44 B (0%) Total Size: 14.8 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start. I've left some comments.
...patient-chart-app/src/visit/visits-widget/past-visits-components/visit-summary.component.tsx
Outdated
Show resolved
Hide resolved
...patient-chart-app/src/visit/visits-widget/past-visits-components/visit-summary.component.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @usamaidrsk.
...patient-chart-app/src/visit/visits-widget/past-visits-components/visit-summary.component.tsx
Outdated
Show resolved
Hide resolved
Could we amend the PR title to something like: "(feat) O3-4088: Sort diagnoses tags in visit summary by rank" |
Co-authored-by: Dennis Kigen <[email protected]>
…#2064) * feat: sort diagnoses by order * feat: sort diagnoses by rank * add suggestions Co-authored-by: Dennis Kigen <[email protected]> * add tests --------- Co-authored-by: Dennis Kigen <[email protected]>
Requirements
Summary
This PR add that diagnoses are properly sorted, with Primary diagnoses appearing first (displayed in red), followed by Secondary diagnoses (displayed in blue).
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-4088
Other