(feat) Vitals header UI enhancements #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -105 kB (-0.67%) Total Size: 15.6 MB
ℹ️ View Unchanged
|
ibacher
approved these changes
Oct 18, 2024
packages/esm-patient-vitals-app/src/vitals-and-biometrics-header/vitals-header.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-vitals-app/src/vitals-and-biometrics-header/vitals-header.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-vitals-app/src/vitals-and-biometrics-header/vitals-header.component.tsx
Outdated
Show resolved
Hide resolved
|
Something I should probably fix in a follow-up PR:
The tag says that these vitals are 4 days old, yet the recorded observations from that date only contain biometrics (not vitals). Maybe the tag should consider only vitals @paulsonder @ciaranduffy |
|
Thanks @dennis. We’ll take a look at the wording in the tag.
…On Fri, 18 Oct 2024 at 20:14, Dennis Kigen ***@***.***> wrote:
Something I should probably fix in a follow-up PR:
***@***.*** (view on web)
<https://github.com/user-attachments/assets/43a1fc2f-879e-41d6-aa78-f1bfe6768ea5>
The tag says that these vitals are *4 days old*, yet the recorded
observations from that date only contain biometrics (not vitals). Should
the tag consider only vitals @paulsonder <https://github.com/paulsonder>
@ciaranduffy <https://github.com/ciaranduffy>?
—
Reply to this email directly, view it on GitHub
<#2069 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWYND7U2CHGX6H6EAKML45TZ4FF2DAVCNFSM6AAAAABQGM62S6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRSHE4TONRSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
senthil-athiban
pushed a commit
to senthil-athiban/openmrs-esm-patient-chart
that referenced
this pull request
Nov 19, 2024
* (feat) Vitals header UI enhancements * Add issue link to comment * Review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR applies an extra set of enhancements to the Vitals header to align it with the designs. These include:
Screenshots
Related Issue
Other