(refactor) Switch visit requests to use promises instead of observables #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ports over requests to the Visit API to use promise-based fetch requests instead of observables. Promises are generally simpler to work with than observables, and this should make the code easier to understand. This change also makes the code more consistent with other requests the frontend makes to the REST API. I've also amended the `UpdateVisitPayload` type annotation to a partial of `NewVisitPayload`, as not all fields are required when updating a visit. We should only really need to provide the stop datetime when ending a visit, for example.
|
Size Change: -44.5 kB (-0.28%) Total Size: 15.8 MB
ℹ️ View Unchanged
|
vasharma05
approved these changes
Oct 25, 2024
Comment on lines
517
to
519
| mutateCurrentVisit(); | ||
| mutateVisits(); | ||
| mutateInfiniteVisits(); |
There was a problem hiding this comment.
Can we make these 3 mutates outside of the if conditions since they are related to the core visit form itself?
There was a problem hiding this comment.
@vasharma05 Let's move that to it's own ticket.
ibacher
approved these changes
Oct 25, 2024
NethmiRodrigo
approved these changes
Oct 25, 2024
senthil-athiban
pushed a commit
to senthil-athiban/openmrs-esm-patient-chart
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Related to and dependent on openmrs/openmrs-esm-core#1184.
Ports over requests to the Visit API to use promise-based fetch requests instead of observables. Promises are generally simpler to work with than observables, and this should make the code easier to understand. This change also makes the code more consistent with other requests the frontend makes to the REST API.
I've also amended the
UpdateVisitPayloadtype annotation to a partial ofNewVisitPayload, as not all fields are required when updating a visit. We should only really need to provide the stop datetime when ending a visit, for example.Screenshots
Related Issue
Other