(feat) O3-4190 Add ability to filter lab orders by type and date #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CynthiaKamau
force-pushed
the
O3-4190
branch
from
ee70867 to
24291c0
Compare
|
Size Change: +1.42 kB (+0.01%) Total Size: 15.9 MB ℹ️ View Unchanged
|
|
Thanks @CynthiaKamau IMO having the backend |
|
Thanks, @CynthiaKamau. Could this be related to the print feature? |
This can save from having to filter on the frontend |
Let me explore that |
CynthiaKamau
force-pushed
the
O3-4190
branch
from
84e84c3 to
01908a8
Compare
CynthiaKamau
force-pushed
the
O3-4190
branch
from
01908a8 to
edd38ea
Compare
donaldkibet
approved these changes
Nov 15, 2024
Comment on lines
197
to
207
| :global .cds--date-picker { | ||
| width: 40%; | ||
|
|
||
| :global .cds--date-picker-container { | ||
| width: 100%; | ||
|
|
||
| :global .cds--date-picker-input__wrapper { | ||
| width: 100%; | ||
|
|
||
| :global .cds--date-picker__input { | ||
| width: 100%; |
There was a problem hiding this comment.
Having this nesting looks not correct.
denniskigen
reviewed
Nov 18, 2024
packages/esm-patient-orders-app/src/components/orders-details-table.component.tsx
Outdated
Show resolved
Hide resolved
denniskigen
reviewed
Nov 18, 2024
packages/esm-patient-orders-app/src/components/orders-details-table.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-orders-app/src/components/orders-details-table.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-orders-app/src/components/orders-details-table.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-orders-app/src/components/orders-details-table.component.tsx
Outdated
Show resolved
Hide resolved
|
Thanks for working on this, @CynthiaKamau. One challenge we'll need to address is that the date comparison doesn't factor in the time. The
|
Would including the time help ? |
|
It would - I'm just concerned about how clunky the UX would be. FWIW, we're trying to tackle the same problem here, so maybe we shouldn't try to solve it in this particular PR. Something worth thinking about though. |
denniskigen
reviewed
Nov 18, 2024
packages/esm-patient-orders-app/src/components/orders-details-table.component.tsx
Outdated
Show resolved
Hide resolved
Would be great to also hear what @ojwanganto and @donaldkibet think since they have a specific use case |
What if the start date is set to 12AM and end day set to 11:59 , end of day? |
CynthiaKamau
force-pushed
the
O3-4190
branch
from
2472f38 to
ce82954
Compare
|
Any suggestions, @dkayiwa, @ibacher, @mogoodrich? |
Our use case is geared towards printing of the orders after applying the filters |
|
Per @dkayiwa, this is a known backend issue. So I think we can merge this and seek a workaround in subsequent PR. |
|
Reminder to self: Update the |
|
@CynthiaKamau could we add some test coverage for the date filtering? |
Sorry @denniskigen I haven't been following this PR... what's the specific question, or are you asking me for an overall review? Thanks! |
@mogoodrich I wanted to know whether this was a known issue with the backend (specifically the Order resource) and whether there's any known workarounds for this. It's basically an issue with how timezones are (or are not) getting dealt with by the backend AFAICT. |
on it |
The ideal rule here is that date / times are stored in UTC in backend and localized based on the client timezone on the frontend, in which case, the "right" thing to do for consistent results display if for the "start date" to start at midnight and the "end date" to end at 11:59:59. While not everything is stored in UTC, I still thing using that time range is appropriate. |
Yeah, there is no good, ideal solution for this, unfortunately. To confirm that it's a time zone issue (sounds like it is) you could confirm that everything works as expected when the client and server are in the same time zone. Not that this is solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Add ability to filter lab orders by type and date
Screenshots
Screen.Recording.2024-11-13.at.14.08.33.mov
Related Issue
Other