(feat): Config to scale the patient identifier sticker content #2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usamaidrsk
reviewed
Dec 5, 2024
| @@ -46,8 +46,8 @@ const PrintIdentifierSticker: React.FC<PrintIdentifierStickerProps> = ({ closeMo | |||
| const handleAfterPrint = useCallback(() => { | |||
| onBeforeGetContentResolve.current = null; | |||
| setIsPrinting(false); | |||
| closeModal(); | |||
| }, [closeModal]); | |||
| // closeModal(); | |||
There was a problem hiding this comment.
Is this something you forgot re-enable
|
Size Change: +228 B (0%) Total Size: 15.9 MB ℹ️ View Unchanged
|
usamaidrsk
approved these changes
Dec 5, 2024
jnsereko
reviewed
Dec 6, 2024
| if (printWindow) { | ||
| const printContent = printWindow.contentDocument || printWindow.contentWindow?.document; | ||
| if (printContent) { | ||
| printContent.documentElement.style.setProperty('--print-scale', printScale); |
There was a problem hiding this comment.
thank you @vasharma05, don't you think we should automate this? ie We scale basing on the sticker size and available window size.
There was a problem hiding this comment.
If it brings some level of complexity, we can leave it as is.
There was a problem hiding this comment.
I tried automating this, but it didn't work for me. Can you help me in the same?
Thanks!
This was referenced Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR adds a new config point to scale the patient identifier sticker content to fit into the small page sizes.
Screenshots
Screen.Recording.2024-12-06.at.01.58.39.mov
Related Issue
None
Other