(refactor) programs-form: Improve error handling and loading states #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves form validation in the Programs form by: - Using React Hook Form's `isSubmitting` state instead of local state - Cleaning up styling for the submit button's loading state - Replacing a custom error message solution with the `Select` component's `invalidText` prop. With this change, we don't need additional styling for the error message.
denniskigen
requested review from
NethmiRodrigo,
jwnasambu,
vasharma05 and
samuelmale
|
Size Change: -116 B (0%) Total Size: 16 MB ℹ️ View Unchanged
|
vasharma05
reviewed
Dec 17, 2024
packages/esm-patient-programs-app/src/programs/programs-form.workspace.tsx
Show resolved
Hide resolved
packages/esm-patient-programs-app/src/programs/programs-form.workspace.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Improves form validation in the Programs form by:
isSubmittingstate instead of local state (should have been fixed in (refactor) Use react hook form's isSubmitting state #2141)Selectcomponent'sinvalidTextprop. With this change, we don't need additional styling for the error message.Screenshots
Validation error message (largely unchanged UI / UX)
Submit button loading state
Related Issue
Other