(feat) Configure showing/hiding reference number fields #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +91 B (0%) Total Size: 16.1 MB ℹ️ View Unchanged
|
vasharma05
changed the title
donaldkibet
requested review from
denniskigen,
usamaidrsk and
brandones
and removed request for
usamaidrsk
usamaidrsk
approved these changes
Jan 13, 2025
|
@vasharma05 could you look into why the build is failing |
denniskigen
reviewed
Jan 13, 2025
| @@ -52,6 +52,7 @@ export function OrderForm({ | |||
| const { orders, setOrders } = useOrderBasket<OrderBasketItem>(orderTypeUuid, prepOrderPostData); | |||
| const [showErrorNotification, setShowErrorNotification] = useState(false); | |||
| const { orderType } = useOrderType(orderTypeUuid); | |||
| const config = useConfig<ConfigObject>(); | |||
There was a problem hiding this comment.
Shouldn't there be corresponding imports for type ConfigObject and useConfig in the diff too?
There was a problem hiding this comment.
I have the imports on my local version of the file.
Let me try re-pushing the changes
Thanks!
There was a problem hiding this comment.
Rebasing resolved the issue
|
Thank you @vasharma05 for implementing this change. It actual address a request from users on the hiding the reference field. |
vasharma05
force-pushed
the
feat/configurable-reference-fields
branch
from
602ccae to
6b0f786
Compare
vasharma05
force-pushed
the
feat/configurable-reference-fields
branch
from
6b0f786 to
139edde
Compare
denniskigen
approved these changes
Jan 13, 2025
3 tasks
Muppasanipraneeth
pushed a commit
to Muppasanipraneeth/openmrs-esm-patient-chart
that referenced
this pull request
Jan 20, 2025
* Make the showing/hiding reference number field configurable * Fix imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR shows/ hides the reference fields in the test and general order forms as per the configuration
Screenshots
Screen.Recording.2025-01-10.at.22.24.57.mov
Related Issue
None
Other