MF-788: Add swr to allergies widget #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
force-pushed
the
MF-788
branch
3 times, most recently
from
1c6145f to
f1b8507
Compare
|
Is this in progress (should be draft) or are you waiting on a review (request some reviewers)? |
|
Ready for review @brandones |
denniskigen
changed the title
brandones
reviewed
Sep 24, 2021
| export const patientAllergiesFormWorkspace = 'patient-allergy-form-workspace'; | ||
| export const allergiesToShowCount = 5; |
There was a problem hiding this comment.
Matter of taste, but I'd just put this in the file it goes with. It's pretty specific to that component.
brandones
approved these changes
Sep 24, 2021
There was a problem hiding this comment.
This rules. The code is shorter, has more robust state handling, and does the awesome SWR stuff. Thanks @denniskigen .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR sets up the allergies widget to work with SWR. It introduces a reusable
useAllergieshook that encapsulates fetching of allergies data from the backend using the SWR paradigm.Additionally, it introduces a call to the SWR mutate function which automatically revalidates the allergies widget data immediately after a new allergy is successfully recorded using the allergy form.
Videos
saving-allergy.mp4
revalidate-on-focus.mp4
showing-potentially-stale-data-while-revalidating.mp4
overview-component-pagination.mp4
Related Issue
https://issues.openmrs.org/browse/MF-788