MF-793: Add SWR to conditions widget #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
changed the title
HerbertYiga
reviewed
Sep 25, 2021
| map((entries) => entries?.map((entry) => entry.resource) ?? []), | ||
| map((data) => formatConditions(data)), | ||
| map((data) => data.sort((a, b) => (b?.onsetDateTime > a?.onsetDateTime ? 1 : -1))), | ||
| export function useConditions(patientUuid: string) { |
brandones
reviewed
Sep 28, 2021
packages/esm-patient-conditions-app/src/conditions/conditions-form.test.tsx
Outdated
Show resolved
Hide resolved
brandones
approved these changes
Sep 28, 2021
Remove the view state reducer logic from the ConditionsForm component code. I'll argue that it only served to make the code unwieldy and harder to reason about. This change shaves 100 lines of boilerplate from the component code as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR:
mutatecall in theConditionsFormso that the related widgets automatically revalidate when a new condition is successfully recorded via the form.Issue
https://issues.openmrs.org/browse/MF-793