Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MF-789: Add swr to notes widget #401

Merged
merged 1 commit into from
Oct 1, 2021
Merged

MF-789: Add swr to notes widget #401

merged 1 commit into from
Oct 1, 2021

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Sep 25, 2021 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

This PR:

  1. Adds SWR data fetching hooks to the Notes widget.
  2. Refactors the existing components to reuse these hooks.
  3. Refactors existing tests to work within the SWR paradigm.
  4. Refactor the VisitNotesForm component code to remove the view state reducer logic. This makes the code shorter and easier to reason about.

Issue

https://issues.openmrs.org/browse/MF-789

@brandones brandones merged commit 08c0c5b into master Oct 1, 2021
@brandones brandones deleted the MF-789 branch October 1, 2021 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandones brandones brandones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denniskigen @brandones