Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MF-794: Add swr to biometrics widget #407

Merged
merged 2 commits into from
Oct 4, 2021
Merged

MF-794: Add swr to biometrics widget #407

merged 2 commits into from
Oct 4, 2021

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Sep 27, 2021 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

This PR:

  1. Adds SWR data fetching hooks to the Biometrics widget.
  2. Refactors the existing components to reuse these hooks.
  3. Refactors existing tests to work within the SWR paradigm.

Issue

https://issues.openmrs.org/browse/MF-794

@denniskigen
Copy link
Member Author

Depends on #405.

brandones
brandones approved these changes Oct 2, 2021
View reviewed changes
Copy link
Contributor

@brandones brandones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same feedback as #405 ; this stuff really needs refactoring, but I really appreciate your keeping this SWR work separate from such refactoring. Adding major refactors to this would make it unreviewable. As is, looks great. Feel free to merge once #405 is in.

@denniskigen denniskigen merged commit 1387516 into master Oct 4, 2021
@denniskigen denniskigen deleted the MF-794 branch October 4, 2021 14:34
@denniskigen
Copy link
Member Author

Thanks, @brandones!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandones brandones brandones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denniskigen @brandones