-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MF-828: The date field in the start visit form is truncated at small display widths #415
Conversation
packages/esm-patient-chart-app/src/visit/visit-form/visit-form.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/visit/visit-form/visit-form.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/visit/visit-form/visit-form.component.tsx
Outdated
Show resolved
Hide resolved
Sorry this got dropped @jnsereko . @donaldkibet and @jnsereko are you able to help finish this? |
hello @brandones @donaldkibet |
Error: Error while trying to collect info after merging MF-828 into master. Error: Command failed: git fetch --no-tags --prune origin refs/pull/415/merge fatal: couldn't find remote ref refs/pull/415/merge at ChildProcess.exithandler (node:child_process:397:12) at ChildProcess.emit (node:events:394:28) at maybeClose (node:internal/child_process:1067:16) at Socket. (node:internal/child_process:453:11) at Socket.emit (node:events:394:28) at Pipe. (node:net:672:12) Generated by @jsenv/file-size-impact during Report bundle size#1959782438 on 1ca6ebb |
Below is a visual expression of the changes add.visit.form.mp4 |
:global(.bx--time-picker), :global(.bx--date-picker-container), :global(.bx--date-picker), :global(#visitStartDateInput) { | ||
width: 100%; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:global
styles on Carbon classes should go in esm-styleguide
.
The global style on #visitStartDateInput
should be changed to a normal scoped class style, i.e.
.visitStartDateInput {
width: 100%;
}
@jnsereko I'm sorry this keeps getting stale. I'll be reviewing it from here forward. Your implementation does not fit the designs: https://app.zeplin.io/project/60d59321e8100b0324762e05/screen/61bb8ae18b41ad4d775c2c0c |
Hello @brandones Thank you for the support. |
@jnsereko Thanks. Please make the date and time inputs flow onto separate lines when the viewport is small. |
hello @brandones @donaldkibet |
That looks good. What does it look like at wider display widths? |
hey @brandones it goes into the same line at widith: 476 and its in different lines below this widith |
hello @brandones |
…display widths
Requirements
Summary
Reduced the Text Date size to allow wraping
Screenshots
7732bd70-c9f2-4f0e-b8c1-0fc894427d51.mp4
None.
Issue
https://issues.openmrs.org/browse/MF-828
Other
None.