Pius/add extension slot to workspace header #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brandones this is the extension slot proposal we discussed on Thursday's squad call. Can you review and merge this? |
|
(While I don't agree with the example UX of adding the toggle to the top workspace nav, we all definitely agree we need another slot here :) ) |
|
Please hold off on this. The design has been altered by Paul.
…Sent from my iPhone
On 20 Oct 2021, at 11:56 AM, grace potma ***@***.***> wrote:
(While I don't agree with the example UX of adding the toggle to the top workspace nav, we all definitely agree we need another slot here :) )
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Thanks Eudson for the clarification. I no longer have concerns on this issue. |
brandones
reviewed
Oct 20, 2021
brandones
reviewed
Oct 20, 2021
brandones
reviewed
Oct 20, 2021
brandones
reviewed
Oct 20, 2021
brandones
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an extension slot to the context workspace
HeaderGlobalBar. The extension gives flexibility to add optional additions to the header.Our use case in OHRI gives users an option to collapse long forms into a minified view. The video shows an implementation where we added a toggle button.
Screenshots
toggle-button.mov