Move extract-translations task to pre-commit hook
#434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`yarn run extract-translations` should run pre-commit so that the updated translation files get committed.
denniskigen
changed the title
extract-translations task to pre-commit hook
brandones
approved these changes
Oct 21, 2021
|
was this issue closed ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
yarn run extract-translationsshould run pre-commit so that the updated translation files get committed.Occasionally, after updating your local branch, you'll see uncommitted translation files show up in your IDE git diff. Moving this task to the pre-commit hook affords the committer a chance to include any potentially updated translations without having to amend their commits or push subsequent commits just for that purpose.