MF-635: Fix patient chart widget card headers #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandones
reviewed
Nov 1, 2021
Comment on lines
+16
to
+23
| h4:after { | ||
| content: ""; | ||
| display: block; | ||
| width: 2rem; | ||
| padding-top: 0.188rem; | ||
| border-bottom: 0.375rem solid $brand-teal-01; | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm thinking it might be nice to factor styles out to esm-patient-chart/esm-patient-common-lib, if that's possible.
There was a problem hiding this comment.
Maybe if this CardHeader was a standalone component in esm-patient-common-lib.
There was a problem hiding this comment.
Ehhhhhh up to you. We can do it in a separate PR if you think it's worth it.
There was a problem hiding this comment.
I've worked on this here.
brandones
approved these changes
Nov 1, 2021
|
Looks like we got conflicts; feel free to merge after fixing. |
denniskigen
force-pushed
the
MF-635-widget-headers
branch
from
6139e20 to
5dd0dce
Compare
denniskigen
added a commit
that referenced
this pull request
Nov 3, 2021
`useLayoutType` is being imported from the wrong package in the ErrorState component - a change mistakenly introduced in #446. As a result, an error is displayed instead of the appointments widget. This commit fixes the import and thus fixes the error.
3 tasks
brandones
pushed a commit
that referenced
this pull request
Nov 3, 2021
* Fix incorrect useLayoutType import `useLayoutType` is being imported from the wrong package in the ErrorState component - a change mistakenly introduced in #446. As a result, an error is displayed instead of the appointments widget. This commit fixes the import and thus fixes the error. * Fix failing AllergyForm test This test was failing because of a missing implementation for `useLayoutType`. Despite a manual mock being available for `esm-framework`, this test suite was overriding that manual mock without providing a suitable alternative (a partial mock or similar). This commit fixes that problem by removing the partial mock of `esm-framework` and relying entirely on the already available manual mock.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR changes the header designs of all the widgets in the patient chart. The card headers should have
3remheight on the desktop viewport and4.5remon a tablet. Additionally, the widget titles on the card headers change depending on the viewport.Screenshots
Desktop
Empty / error state
Tablet
Issue
https://issues.openmrs.org/projects/MF/issues/MF-635