O3-935: Apply shadow to corner grid element on scroll #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply a box shadow effect to the corner grid element when the Timeline Overview is scrolled horizontally. This should have been included in #462. Additionally, this commit makes some improvements to type annotations.
brandones
approved these changes
Dec 2, 2021
|
Am a developer, I need to contribute on some projects
…On Thu, Dec 2, 2021, 10:03 PM Brandon Istenes ***@***.***> wrote:
Merged #470
<#470> into
master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#470 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVB4A4GFEGT2UNGD7PREZATUO67JNANCNFSM5IYHBIEQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Apply a box shadow effect to the corner grid element when the Timeline Overview gets scrolled horizontally. This should have been included in #462.
Additionally, this commit makes some improvements to type annotations in the Timeline Overview component.
Screenshots
Issue
https://issues.openmrs.org/browse/O3-935