Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to the Allergies Form #487

Merged
merged 4 commits into from
Jan 14, 2022
Merged

Enhancements to the Allergies Form #487

merged 4 commits into from
Jan 14, 2022

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Jan 5, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

Wide-ranging enhancements to the Allergies form. These include:

  • Displaying the patient details header above the form when in tablet mode.
  • Rendering allergens and reactions in a two-column layout when in tablet mode.
  • Applying a lot of style fixes based on the available designs.
  • Disabling the Submit button until a user has selected an allergen to avoid invalid submissions (the allergen field is required). Additionally, should the user check the Other allergen field, we now check to see that they've provided an allergen name in the text input that appears before enabling the Submit button.
  • Code improvements that include:
    • Better type annotations.
    • Deleting unnecessary styles and types.
    • Limiting the specificity of certain SASS style overrides so they don't pollute the global scope.

Screenshots

  • Desktop

Screenshot 2022-01-06 at 00 27 25

Screenshot 2022-01-06 at 00 27 37

  • Tablet

Screenshot 2022-01-06 at 00 25 57

Screenshot 2022-01-06 at 00 26 13

@denniskigen denniskigen marked this pull request as ready for review January 6, 2022 19:07
Copy link
Member

@jonathandick jonathandick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathandick
Copy link
Member

@denniskigen would you mind fixing conflicts and then merging?

@denniskigen
Copy link
Member Author

Thanks for the reviews!

@denniskigen denniskigen merged commit 07ea10b into master Jan 14, 2022
@denniskigen denniskigen deleted the allergies-form branch January 14, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants