O3-976: Share Patient Chart Common Lib #503
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Right now the common lib is duplicated for each MF of patient-chart. Now, with dynamic module sharing in place we should actually add it to the dynamically shared libs.
Screenshots
None.
Issue
See O3-976.
Other
For whatever reason I cannot log in locally. Always get unauthenticated as response when entering the credentials. This was the same behavior as online at https://openmrs-spa.org/openmrs/spa/login. So I guess its a current backend issue.