Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-976: Share Patient Chart Common Lib #503

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

FlorianRappl
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

Right now the common lib is duplicated for each MF of patient-chart. Now, with dynamic module sharing in place we should actually add it to the dynamically shared libs.

Screenshots

None.

Issue

See O3-976.

Other

For whatever reason I cannot log in locally. Always get unauthenticated as response when entering the credentials. This was the same behavior as online at https://openmrs-spa.org/openmrs/spa/login. So I guess its a current backend issue.

Copy link
Member

@manuelroemer manuelroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

For whatever reason I cannot log in locally. Always get unauthenticated as response when entering the credentials.

I had the same issue with the admin account, but admin2 (same PW) still works for me. Maybe that also works for you.

@FlorianRappl
Copy link
Contributor Author

I had the same issue with the admin account, but admin2 (same PW) still works for me. Maybe that also works for you.

Works - thanks!

@FlorianRappl
Copy link
Contributor Author

FlorianRappl commented Jan 13, 2022

Alright, tested and works (on my machine 🦑 ).

@FlorianRappl FlorianRappl merged commit 1b84b35 into master Jan 13, 2022
@donaldkibet donaldkibet deleted the feature/o976-share-common-lib branch April 23, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants